-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller runtime update #329
Controller runtime update #329
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
03a30f3
to
45c56a1
Compare
45c56a1
to
ea8117d
Compare
fab0200
to
b7a8b53
Compare
Signed-off-by: Brendan Shephard <[email protected]>
This change updates the webhook functions to comply with the new standard for controller-runtime. Signed-off-by: Brendan Shephard <[email protected]>
This change updates the manager intialisation to comply with the new controller-runtime schema. Signed-off-by: Brendan Shephard <[email protected]>
This change fixes the Watches declarations to comply with the new controller-runtime standards. Signed-off-by: Brendan Shephard <[email protected]> Fix new watches Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
b7a8b53
to
6091039
Compare
Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
@bshephar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…rators/renovate/openstack-k8s-operators Update openstack-k8s-operators
This changes updates the controller-runtime and fixes the initialisation of objects to comply with the new controller-runtime standards. Namely:
We fix the function signatures of the webhook to include admissions.Warnings:
kubernetes-sigs/controller-runtime@8770b4d
We fix the initialisation of the manager to declare the webhook following the new schema:
kubernetes-sigs/controller-runtime@91cdd8c
We fix the Watches function to comply with the new signature definition:
kubernetes-sigs/controller-runtime@dc62ed5
Add context to EventHandlers:
kubernetes-sigs/controller-runtime@2464a9d