Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples: Add Dell PowerMax ISCSI backend samples #331

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

jproque-dell
Copy link
Contributor

No description provided.

Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

Hi @jproque-dell. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a new backend sample.

Please add your driver to the list of available cinder backend samples (https://github.com/openstack-k8s-operators/cinder-operator/tree/main/config/samples/backends) and squash the PR commits into a single commit.

Review note: There is no need for a custom container even though the driver has OpenSSL python package as a dependency because the cinder-volume container already includes it.

@jproque-dell jproque-dell requested a review from Akrog February 19, 2024 10:47
@Akrog Akrog added ok-to-test tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed needs-ok-to-test labels Feb 20, 2024
@jproque-dell jproque-dell requested a review from Akrog February 20, 2024 19:48
Copy link
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 20, 2024
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, jproque-dell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 43226b6 into openstack-k8s-operators:main Feb 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants