-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samples: Add Dell PowerMax ISCSI backend samples #331
Samples: Add Dell PowerMax ISCSI backend samples #331
Conversation
Hi @jproque-dell. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a new backend sample.
Please add your driver to the list of available cinder backend samples (https://github.com/openstack-k8s-operators/cinder-operator/tree/main/config/samples/backends) and squash the PR commits into a single commit.
Review note: There is no need for a custom container even though the driver has OpenSSL python package as a dependency because the cinder-volume container already includes it.
config/samples/backends/dell/powermax/iscsi/cinder-volume-powermax-secrets.yaml
Outdated
Show resolved
Hide resolved
Remove empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, jproque-dell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
43226b6
into
openstack-k8s-operators:main
No description provided.