Backend Samples: place on worker nodes #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current samples are deploying MachineConfigs on master nodes, which works just fine because right now all our master nodes are also worker nodes, but is not technically correct. This patch updates the MachineConfigs to deploy on worker nodes, which is the technically correct location.
ASBishop
approved these changes
Feb 12, 2024
| @@ -2,10 +2,10 @@ apiVersion: machineconfiguration.openshift.io/v1 | |||
| kind: MachineConfig | |||
| metadata: | |||
| labels: | |||
| machineconfiguration.openshift.io/role: master | |||
| machineconfiguration.openshift.io/role: worker | |||
| service: cinder | |||
| component: cinder-volume | |||
There was a problem hiding this comment.
Independent of this PR (which looks fine), we'll need to ensure this machineConfig is applied to only one worker, and the associated c-vol service is constrained to that worker.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, ASBishop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 60a9aba
into
openstack-k8s-operators:main
7 checks passed
ASBishop
pushed a commit
to ASBishop/cinder-operator
that referenced
this pull request
Mar 11, 2024
…rators/renovate/openstack-k8s-operators Update openstack-k8s-operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current samples are deploying MachineConfigs on master nodes, which works just fine because right now all our master nodes are also worker nodes, but is not technically correct.
This patch updates the MachineConfigs to deploy on worker nodes, which is the technically correct location.