Revert "Backend Samples: place on worker nodes" #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9ef753e, where we tried to pin the `MachineConfig` to the `worker` role, because they don't work. Even if the OpenShift CRC node has both master and worker roles, that doesn't mean that we can use them for the `MachineConfig`, because the thing that ties together a `MachineConfig` to a `Machine` is the `MachineConfigPool` and a `Machine` can only belong to one `MachineConfigPool`. And looking at the available `Machine` in a CRC deployment we see that it has the master role. ``` Name: crc-ksq4m-master-0 Namespace: openshift-machine-api Labels: machine.openshift.io/cluster-api-cluster=crc-ksq4m machine.openshift.io/cluster-api-machine-role=master machine.openshift.io/cluster-api-machine-type=master ``` And looking at the `MachineConfigPool` we see that only the `master` pool has machine assigned to it. ``` NAME CONFIG UPDATED UPDATING DEGRADED MACHINECOUNT READYMACHINECOUNT UPDATEDMACHINECOUNT DEGRADEDMACHINECOUNT AGE master rendered-master-e542525f4afc269344cc5e648a41f812 True False False 1 1 1 0 34d worker rendered-worker-c36181deab728b3d19199b5b7dd30332 True False False 0 0 0 0 34d ```
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, ASBishop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 98deddd
into
openstack-k8s-operators:main
7 checks passed
ASBishop
pushed a commit
to ASBishop/cinder-operator
that referenced
this pull request
Mar 11, 2024
…rators/renovate/openstack-k8s-operators Update openstack-k8s-operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9ef753e, where we tried to pin the
MachineConfigto theworkerrole, because they don't work.Even if the OpenShift CRC node has both master and worker roles, that doesn't mean that we can use them for the
MachineConfig, because the thing that ties together aMachineConfigto aMachineis theMachineConfigPooland aMachinecan only belong to oneMachineConfigPool.And looking at the available
Machinein a CRC deployment we see that it has the master role.And looking at the
MachineConfigPoolwe see that only themasterpool has machine assigned to it.