Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backend samples using custom images #416

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/samples/backends/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ changes.

Some backends, like 3PAR and Pure, require a custom container because they have
external dependencies. So there is a need to build a specific container. In
RHOSP, vendors will provide certified containers through Red Hat's container
RHOSO, vendors will provide certified containers through Red Hat's container
image registry. For illustration and development purposes this repository
provides samples of what a `Dockerfile` would look like for each of the
vendor's. This `Dockerfile` will be present in the vendor's directory (e.g.
`hpe/Dockerfile` and `pure/Dockerfile`), so we would need to build a container,
make it available in a registry, and then provide it to the cinder operator via
the `containerImage` as seen in the samples.
the `OpenStackVersion` CR as seen in the samples.

## Ceph example

Expand Down
2 changes: 0 additions & 2 deletions config/samples/backends/hpe/3par/fc/backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ spec:
hpe3par-fc:
networkAttachments:
- storage
# This image exists and was built using the Dockerfile available in the grandparent directory
containerImage: quay.io/geguileo/podified-antelope-openstack-cinder-volume-3par:current-podified
customServiceConfigSecrets:
- cinder-volume-3par-secrets
customServiceConfig: |
Expand Down
9 changes: 9 additions & 0 deletions config/samples/backends/hpe/3par/fc/custom-container.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: core.openstack.org/v1beta1
kind: OpenStackVersion
metadata:
name: openstack
spec:
customContainerImages:
cinderVolumeImages:
# This image exists and was built using the Dockerfile available in the grandparent directory
hpe3par-fc: quay.io/geguileo/podified-antelope-openstack-cinder-volume-3par:current-podified
1 change: 1 addition & 0 deletions config/samples/backends/hpe/3par/fc/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ resources:
- ../../../bases/multipathd
- ../../../bases/openstack
- cinder-volume-3par-secrets.yaml
- custom-container.yaml
patches:
- path: backend.yaml
2 changes: 0 additions & 2 deletions config/samples/backends/hpe/3par/iscsi/backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ spec:
hpe3par-iscsi:
networkAttachments:
- storage
# This image exists and was built using the Dockerfile available in the grandparent directory
containerImage: quay.io/geguileo/podified-antelope-openstack-cinder-volume-3par:current-podified
customServiceConfigSecrets:
- cinder-volume-3par-secrets
customServiceConfig: |
Expand Down
9 changes: 9 additions & 0 deletions config/samples/backends/hpe/3par/iscsi/custom-container.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: core.openstack.org/v1beta1
kind: OpenStackVersion
metadata:
name: openstack
spec:
customContainerImages:
cinderVolumeImages:
# This image exists and was built using the Dockerfile available in the grandparent directory
hpe3par-iscsi: quay.io/geguileo/podified-antelope-openstack-cinder-volume-3par:current-podified
1 change: 1 addition & 0 deletions config/samples/backends/hpe/3par/iscsi/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ resources:
- ../../../bases/iscsid
- ../../../bases/multipathd
- ../../../bases/openstack
- custom-container.yaml
- cinder-volume-3par-secrets.yaml
patches:
- path: backend.yaml
2 changes: 0 additions & 2 deletions config/samples/backends/pure/fc/backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ spec:
pure-fc:
networkAttachments:
- storage
# This image exists and was built using the Dockerfile available in the parent directory
containerImage: quay.io/geguileo/podified-antelope-openstack-cinder-volume-pure:current-podified
# Configuration details available at
# https://pure-storage-openstack-docs.readthedocs.io/en/latest/cinder/ch_cinder-configuration.html
customServiceConfigSecrets:
Expand Down
9 changes: 9 additions & 0 deletions config/samples/backends/pure/fc/custom-container.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: core.openstack.org/v1beta1
kind: OpenStackVersion
metadata:
name: openstack
spec:
customContainerImages:
cinderVolumeImages:
# This image exists and was built using the Dockerfile available in the parent directory
pure-fc: quay.io/geguileo/podified-antelope-openstack-cinder-volume-pure:current-podified
1 change: 1 addition & 0 deletions config/samples/backends/pure/fc/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
resources:
- ../../bases/multipathd
- ../../bases/openstack
- custom-container.yaml
- cinder-volume-pure-secrets.yaml
patches:
- path: backend.yaml
2 changes: 0 additions & 2 deletions config/samples/backends/pure/iscsi/backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ spec:
pure-iscsi:
networkAttachments:
- storage
# This image exists and was built using the Dockerfile available in the parent directory
containerImage: quay.io/geguileo/podified-antelope-openstack-cinder-volume-pure:current-podified
# Configuration details available at
# https://pure-storage-openstack-docs.readthedocs.io/en/latest/cinder/ch_cinder-configuration.html
customServiceConfigSecrets:
Expand Down
9 changes: 9 additions & 0 deletions config/samples/backends/pure/iscsi/custom-container.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: core.openstack.org/v1beta1
kind: OpenStackVersion
metadata:
name: openstack
spec:
customContainerImages:
cinderVolumeImages:
# This image exists and was built using the Dockerfile available in the grandparent directory
pure-iscsi: quay.io/geguileo/podified-antelope-openstack-cinder-volume-3par:current-podified
1 change: 1 addition & 0 deletions config/samples/backends/pure/iscsi/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ resources:
- ../../bases/iscsid
- ../../bases/multipathd
- ../../bases/openstack
- custom-container.yaml
- cinder-volume-pure-secrets.yaml
patches:
- path: backend.yaml
2 changes: 0 additions & 2 deletions config/samples/backends/pure/nvme-roce/backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ spec:
pure-nvme-roce:
networkAttachments:
- storage
# This image exists and was built using the Dockerfile available in the parent directory
containerImage: quay.io/geguileo/podified-antelope-openstack-cinder-volume-pure:current-podified
# Configuration details available at
# https://pure-storage-openstack-docs.readthedocs.io/en/latest/cinder/ch_cinder-configuration.html
customServiceConfigSecrets:
Expand Down
9 changes: 9 additions & 0 deletions config/samples/backends/pure/nvme-roce/custom-container.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
apiVersion: core.openstack.org/v1beta1
kind: OpenStackVersion
metadata:
name: openstack
spec:
customContainerImages:
cinderVolumeImages:
# This image exists and was built using the Dockerfile available in the grandparent directory
pure-nvme-roce: quay.io/geguileo/podified-antelope-openstack-cinder-volume-3par:current-podified
1 change: 1 addition & 0 deletions config/samples/backends/pure/nvme-roce/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ resources:
- ../../bases/nvmeof
- ../../bases/multipathd
- ../../bases/openstack
- custom-container.yaml
- cinder-volume-pure-secrets.yaml
patches:
- path: backend.yaml
Loading