-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0-fr1] Ensure nodeSelector logic is consistent for all operators #469
[18.0-fr1] Ensure nodeSelector logic is consistent for all operators #469
Conversation
Switch to a pointer for nodeSelector to allow different logic for empty vs unset
There is no need drop empty nodeSelector maps, omitempty already does this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test cinder-operator-build-deploy |
/test cinder-operator-build-deploy-tempest |
/test cinder-operator-build-deploy-kuttl |
/override ci/prow/cinder-operator-build-deploy ci/prow/cinder-operator-build-deploy-kuttl ci/prow/cinder-operator-build-deploy-tempest |
@olliewalsh: Overrode contexts on behalf of olliewalsh: ci/prow/cinder-operator-build-deploy, ci/prow/cinder-operator-build-deploy-kuttl, ci/prow/cinder-operator-build-deploy-tempest In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c716f59
into
openstack-k8s-operators:18.0-fr1
This is an automated cherry-pick of #466
/assign olliewalsh