Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure keystonemiddleware to deal with memcached pods failures #472

Conversation

lmiccini
Copy link
Contributor

Whenever one of the mecached pods disappears, because of a rolling restart during a minor update or as result of a failure, APIs can take a long time to detect that the pod went away and keep trying to reconnect.

From a quick round of tests we saw downtimes up to ~150s.

By tuning memcache_pool_dead_retry and memcache_pool_conn_get_timeout the behavior seems much more acceptable.

Jira: https://issues.redhat.com/browse/OSPRH-11935

Whenever one of the mecached pods disappears, because of a rolling
restart during a minor update or as result of a failure, APIs can
take a long time to detect that the pod went away and keep trying
to reconnect.

From a quick round of tests we saw downtimes up to ~150s.

By tuning memcache_pool_dead_retry and memcache_pool_conn_get_timeout
the behavior seems much more acceptable.

Jira: https://issues.redhat.com/browse/OSPRH-11935
@openshift-ci openshift-ci bot requested review from Akrog and frenzyfriday November 29, 2024 12:39
@fmount
Copy link
Contributor

fmount commented Dec 4, 2024

/test cinder-operator-build-deploy-tempest

@fmount
Copy link
Contributor

fmount commented Dec 5, 2024

Tested locally and it works as expected. We might want to document how to tune these parameters but the default values are aligned with the rest of the operators.

@fmount fmount requested review from ASBishop and fmount December 5, 2024 10:10
@fmount
Copy link
Contributor

fmount commented Dec 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
@fmount fmount requested a review from stuggi December 5, 2024 10:11
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmiccini, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c81163f into openstack-k8s-operators:main Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants