-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logically bound images for EDPM services #39
base: main
Are you sure you want to change the base?
Add logically bound images for EDPM services #39
Conversation
9a2602d
to
7f1ca6e
Compare
bootc/Containerfile.centos9
Outdated
COPY embedded-services/quadlets/multipathd/multipathd.yaml /usr/share/containers/systemd/multipathd.yaml | ||
COPY embedded-services/quadlets/multipathd/multipathd.image /usr/share/containers/systemd/multipathd.image | ||
COPY embedded-services/quadlets/ceilometer_agent_compute/ceilometer_agent_compute.yaml /usr/share/containers/systemd/ceilometer_agent_compute.yaml | ||
COPY embedded-services/quadlets/ceilometer_agent_compute/ceilometer_agent_compute.image /usr/share/containers/systemd/ceilometer_agent_compute.image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each directive creates a layer, if all the files were in the quadlets directory this could become a single directive:
COPY embedded-services/quadlets/* /usr/share/containers/systemd/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll squash them all once this is ready to go. I don't see any issue with them all being in one layer
RUN podman pull quay.io/podified-antelope-centos9/openstack-multipathd:current-podified | ||
RUN podman pull quay.io/podified-antelope-centos9/openstack-nova-compute:current-podified | ||
RUN podman pull quay.io/podified-antelope-centos9/openstack-ovn-controller:current-podified | ||
RUN podman pull quay.io/podified-antelope-centos9/openstack-neutron-metadata-agent-ovn:current-podified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want each pull in its own layer? I don't know?? If we didn't then this could be reduced to a single RUN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually isn't working anymore. Complains about things not being available in the container environment. I'm actually noticing the same error with my laptop bootc image too. Maybe something changed in the base edpm centos image. For now, I'm just commenting these lines when I build the image and letting systemd
pull the containers when the node boots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these commands give me a lot of cannot set user namespace
errors. sometimes it works, sometimes it doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did get a successful build by adding a USER root
before the podman pull commands. Not sure if it was just random, or if it actually made a difference. I though the default user was root anyway.
39bcd79
to
2da9f5a
Compare
This change adds logically bound images for use with bootc. This is implementing based on: https://containers.github.io/bootc/logically-bound-images.html Signed-off-by: Brendan Shephard <[email protected]>
1659a11
to
b7bc09a
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6cd41fcfa86443e89d4286d9870ddd75 ✔️ eib-content-provider-build-images SUCCESS in 1h 02m 13s |
b7bc09a
to
d0c72b7
Compare
Signed-off-by: Brendan Shephard <[email protected]>
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4a956ce329eb4fb995be4bab5e3572d1 ❌ eib-content-provider-build-images FAILURE in 4m 21s |
57e3ccd
to
561650e
Compare
This change adds logically bound images for use with bootc. This is implementing based on: https://containers.github.io/bootc/logically-bound-images.html Signed-off-by: Brendan Shephard <[email protected]> Add QEMU to image Quadlet files in correct location pyroute
d3d98a3
to
f21a11d
Compare
name: novacompute | ||
spec: | ||
containers: | ||
- args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be moved to an actual initContainer. Otherwise the pod will be degraded once this exits.
Signed-off-by: Brendan Shephard <[email protected]>
f21a11d
to
fe3c83c
Compare
tmpwatch \ | ||
tuned-profiles-cpu-partitioning \ | ||
qemu-kvm" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't re-format from spaces to tabs
RUN podman pull quay.io/podified-antelope-centos9/openstack-multipathd:current-podified | ||
RUN podman pull quay.io/podified-antelope-centos9/openstack-nova-compute:current-podified | ||
RUN podman pull quay.io/podified-antelope-centos9/openstack-ovn-controller:current-podified | ||
RUN podman pull quay.io/podified-antelope-centos9/openstack-neutron-metadata-agent-ovn:current-podified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these commands give me a lot of cannot set user namespace
errors. sometimes it works, sometimes it doesn't.
ARG ENABLE_UNITS="openvswitch" | ||
|
||
RUN dnf -y update && dnf -y install $PACKAGES && dnf clean all && systemctl enable $ENABLE_UNITS | ||
RUN sudo dnf install centos-release-nfv-openvswitch centos-release-openstack-dalmatian -y && dnf -y install $PACKAGES && dnf clean all && systemctl enable $ENABLE_UNITS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are you getting the rpms centos-release-nfv-openvswitch centos-release-openstack-dalmatian from? you must be customizing the repo-setup command for the build somehow?
those are available on the base quay.io/centos-bootc/centos-bootc:stream9 image, but since our first command is RUN rm -rf /etc/yum.repos.d/*.repo, the enabled repos get removed, and then those packages are no longer available
This change adds logically bound images for use with bootc. This is implementing based on: https://containers.github.io/bootc/logically-bound-images.html