Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSPRH-12378] Set X-Forwarded-Proto only if empty #584

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlarriba
Copy link
Collaborator

No description provided.

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlarriba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vyzigold
Copy link
Contributor

This looks good, but I'm wondering if we need something similar for aodh

@jlarriba
Copy link
Collaborator Author

This looks good, but I'm wondering if we need something similar for aodh

That conf file is currently lacking the line we are replacing:

RequestHeader set X-Forwarded-Proto "https"

I wonder if this was a bug or intended.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b30c45477d4b47a997af0a49f243b39d

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 29s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 15s
✔️ telemetry-operator-multinode-autoscaling-tempest SUCCESS in 1h 08m 55s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 16m 48s
✔️ telemetry-operator-multinode-power-monitoring SUCCESS in 45m 43s
functional-tests-on-osp18 FAILURE in 1h 51m 48s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 06m 15s
functional-graphing-tests-osp18 FAILURE in 1h 05m 19s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 05m 36s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants