A better way to fix DAG import test #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ireneisdoomed
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes opentargets/issues#3140 (again -__-)
After the fix in #218 it turned out that pytest's
DagBagimport and the actual Airflow deployment still differ in how they treat imports. In particular, "from . import airflow_common" imports work in pytest, but not in the actual Airflow set up.After digging further, it looks like the proper way to make pytest evaluate those files is to extend its PYTHONPATH (not PATH and not the current working directory).
My apologies for the mix-up, the new configuration should now fix things for good.