-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: carma outlier detection method #281
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #281 +/- ##
==========================================
+ Coverage 85.67% 86.84% +1.17%
==========================================
Files 89 92 +3
Lines 2101 2433 +332
==========================================
+ Hits 1800 2113 +313
- Misses 301 320 +19
|
Co-authored-by: Yakov Tsepilov <[email protected]>
Co-authored-by: Yakov Tsepilov <[email protected]>
Co-authored-by: Yakov Tsepilov <[email protected]>
ad55ccc
to
dcb8fac
Compare
for more information, see https://pre-commit.ci
You can easily get 100% testing coverage by adding additional examples that evaluate the conditions (if statements) that you are currently missing. Have a look at the red lines here: |
for more information, see https://pre-commit.ci
@d0choa I can add two more tests to cover red lines 288-296. But not for others - specific extreme cases that very hard to reach since they are using intermediate output of the functions. |
@d0choa I have added two tests. For now this is the biggest coverage I can get. |
@DSuveges we need approval here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some minor style comments, but overall everything looks good to me
@DSuveges could you please help to resolve the conflict in poetry.lock? |
Co-authored-by: Kirill Tsukanov <[email protected]>
Co-authored-by: Kirill Tsukanov <[email protected]>
Co-authored-by: Kirill Tsukanov <[email protected]>
Co-authored-by: Kirill Tsukanov <[email protected]>
CARMA outlier detection method: