Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(study_locus): remove statistics after conditioning from schema #383

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

ireneisdoomed
Copy link
Contributor

This PR includes:

  • deletion of the variant statistics after conditioning from the StudyLocus schema

Context

Inside a locus, we have a couple of statistics that describe the association between a variant and the trait after doing conditional analysis.
COJO does conditioning, and that is why we were maintaining these fields. However our current implementation does not include adjusting the p values based on other signals in the locus.

Given the current size of our locus object, I think we're better off without these null fields polluting the codebase.

Copy link
Contributor

@addramir addramir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes. But if we want to get rid of COJO stats we need to also rename - "logABF" to "logBF" in study_locus.json

@ireneisdoomed
Copy link
Contributor Author

if we want to get rid of COJO stats we need to also rename - "logABF" to "logBF"

@addramir Thank you for the comment, one question about colocalisation. The COLOC implementation i know uses ABFs to do the hypothesis testing (see here). Can I double check that we can just exchange ABFs with BFs and achieve the same?

@addramir
Copy link
Contributor

addramir commented Jan 3, 2024

Yes, you can. It is basically the same, just some terminological issues.

Copy link
Contributor

@addramir addramir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Irene, for changing ABF to BF it is better to open another PR.

@ireneisdoomed ireneisdoomed merged commit ee79424 into dev Jan 4, 2024
3 checks passed
@ireneisdoomed ireneisdoomed deleted the il-trim-locus branch January 4, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants