feat(study_locus): remove statistics after conditioning from schema #383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Context
Inside a
locus
, we have a couple of statistics that describe the association between a variant and the trait after doing conditional analysis.COJO does conditioning, and that is why we were maintaining these fields. However our current implementation does not include adjusting the p values based on other signals in the locus.
Given the current size of our locus object, I think we're better off without these null fields polluting the codebase.