Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean documentation page about version engine #960

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

project-defiant
Copy link
Contributor

@project-defiant project-defiant commented Dec 17, 2024

✨ Context

Cleanup after the drop of the datasource version engine, that I missed last time.

πŸ›  What does this PR implement

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@github-actions github-actions bot added documentation Improvements or additions to documentation Chore size-XS labels Dec 17, 2024
@project-defiant project-defiant marked this pull request as ready for review January 14, 2025 12:57
Copy link
Contributor

@DSuveges DSuveges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@DSuveges DSuveges merged commit 45ff1be into dev Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore documentation Improvements or additions to documentation size-XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants