Process boarding location for linear platforms #6247
Conversation
|
We talked about this today and we came to the conclusion that we want to introduce a data structure that is available during graph build only and then discarded. Lets discuss this in a meeting. |
|
Does moving the |
|
Unfortuntately not. We want to design a new system for keeping information that is used during graph build only and then discarded. |
miklcct
force-pushed
the
boarding-locations
branch
from
185a5b8 to
89b3ac7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6247 +/- ##
=============================================
+ Coverage 69.85% 69.88% +0.03%
- Complexity 17921 17950 +29
=============================================
Files 2035 2038 +3
Lines 76495 76581 +86
Branches 7824 7826 +2
=============================================
+ Hits 53434 53519 +85
- Misses 20324 20327 +3
+ Partials 2737 2735 -2 ☔ View full report in Codecov by Sentry. |
|
@t2gran will come with some suggestions of how to solve this without adding anything to the serialized graph. |
|
There is one thing I do not understand here. Is it true that in the OSM model the boarding reference can be on both way and node, and that it is only on Vertex in OTP? If so, why are we not just coping the boarding references to the vertexes it is connected to? I think the correct behavior for the routing would be to "arrive at the stop" when you arrive at one of the vertexes included in the platform. |
|
I think your behaviour is correct but it isn't supported even for the area platforms yet. The centroid is currently calculated and used. Maybe I should try to connect the stop to every vertexes instead (and also do it for area platforms as well) |
|
I am almost done with storing the refs between builders, so I will publish that here when I am done. Lets, discuss this on Tuesday again. I would like some feedback from the "AStar experts" on how to NOT model a stop as a point? This is likely to be a bigger refactoring, but for some stops modeling it as a point is problematic. |
…modules The Repository and Service is not available during routing, only during the graph build.
|
Here is how you can excange data between builders - the data is persserved during serialization: |
habrahamsson-skanetrafiken
requested review from
vesameskanen
and removed request for
vesameskanen
miklcct
force-pushed
the
boarding-locations
branch
from
30e6bd6 to
d40d0b3
Compare
miklcct
force-pushed
the
boarding-locations
branch
from
0afdc47 to
eaafc68
Compare
application/src/main/java/org/opentripplanner/routing/linking/VertexLinker.java
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/service/osminfo/OsmInfoGraphBuildRepository.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Leonard Ehrenfried <[email protected]>
| Platform platform = platformEdgeList.getKey(); | ||
| var name = platform.name(); | ||
| var label = "platform-centroid/%s".formatted(stop.getId().toString()); | ||
| var centroid = platform.geometry().getCentroid(); | ||
| var boardingLocation = vertexFactory.osmBoardingLocation( | ||
| new Coordinate(centroid.getX(), centroid.getY()), | ||
| label, | ||
| platform.references(), | ||
| name | ||
| ); |
There was a problem hiding this comment.
This is copy&paste. Please extract a method.
| @@ -99,14 +113,14 @@ public void buildGraph() { | |||
| } | |||
|
|
|||
| private boolean connectVertexToStop(TransitStopVertex ts, StreetIndex index) { | |||
There was a problem hiding this comment.
This method is getting too large. Please extract three methods for the three cases:
- Node
- Area
- Way
Move the inline comments into Javadoc.
Summary
This adds the processing of boarding locations on linear platforms.
Fixes #6056
Unit tests
added
Documentation
None
Bumping the serialization version id
No longer needed