Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use positional argument for input files in 2john scripts #5649

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

exploide
Copy link
Contributor

@exploide exploide commented Jan 6, 2025

As requested in #5643 (comment) this PR turns the input file arguments for radius2john.py and aix2john.py into positional arguments.

Plus a bit of cleanup while I was at it.

Copy link
Member

@magnumripper magnumripper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I see radius2john also takes pcap so presumedly the reason for it not being a part of pcap2john is the potential need for -l and -p.

I tested radius2john with our samples, we don't seem to have any samples for AIX.

@exploide
Copy link
Contributor Author

exploide commented Jan 7, 2025

we don't seem to have any samples for AIX.

The only bit I found was in the comment at the beginning of the script. I copied that to a file and the script produced the same output on it.

@solardiz solardiz merged commit 9446114 into openwall:bleeding-jumbo Jan 20, 2025
35 of 36 checks passed
@exploide exploide deleted the 2john-cleanup branch January 20, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants