Fetch-timeout #269
Open
Fetch-timeout #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
cre8
requested review from
lukasjhan,
aceshim,
zustkeeper and
berendsliedrecht
as code owners
lukasjhan
reviewed
Jan 20, 2025
| @@ -187,12 +180,10 @@ export class SDJwtVcInstance extends SDJwtInstance<SdJwtVcPayload> { | |||
| await this.validateIntegrity(response.clone(), url, integrity); | |||
| return response.json() as Promise<T>; | |||
| } catch (error) { | |||
| if (error instanceof DOMException && error.name === 'AbortError') { | |||
| if (error instanceof DOMException && error.name === 'TimeoutError') { | |||
There was a problem hiding this comment.
Is the DOMException okay for other platform? RN or nodejs?
There was a problem hiding this comment.
I ran the test with as browser and as node (provided by the package file). In both cases I got a TimeoutError.
As mentioned I don't have a RN setup so I am unable to test it. A quick check of the react native github repo assumes that it should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the newer version of the abort signal, also add a test for it
Addressing the discussion from #267
Signed-off-by: Mirko Mollik [email protected]