wiki: openwrt naming fixes and contribution improvement #25731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrumpyMeow
changed the title
Haha, my pet peeve! Thanks for that one. Looks good to me. |
GrumpyMeow
force-pushed
the
feature_markdown_docs_improvement
branch
from
a6e8e19 to
13291b6
Compare
Signed-off-by: Sander Schutten <[email protected]>
GrumpyMeow
force-pushed
the
feature_markdown_docs_improvement
branch
from
13bbd5d to
9782b35
Compare
1715173329
approved these changes
Jan 15, 2025
| "General Build Settings" set if language support is relevant to your package. | ||
| - Best of all -- it works as expected! | ||
| - The compilation has been successfully tested with the appropriate includes and dependencies. | ||
| Additionally, if language support is relevant to your package, please enable the "Compile with full language support" option found under "Global Build Settings" in "menuconfig" and conduct further tests. |
There was a problem hiding this comment.
this looks pretty long, would be better to wrap a new line
| - <strong>PKG_SOURCE</strong> should reference the smallest available archive. In order of | ||
| preference: | ||
| 1. xz (most compressed), | ||
| 1. bzip2, gz and zip. |
There was a problem hiding this comment.
Markdown does the numbering automatically upon viewing. So I left this on-purpose like this.
There was a problem hiding this comment.
yep but this is confusing when review the source code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: various
Description:
With this PR i:
Made this PR with best intentions. No problem if unable to complete this PR.