-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isa_defs.h: fix freebsd loongarch compilation errors("ISA not support… #16821
Conversation
checkstyle says
but what I really wanted - you can ignore the |
92b7482
to
37dec38
Compare
I have resubmitted.
I am unable to run resilver_restart_001 |
@@ -159,6 +159,16 @@ extern "C" { | |||
#endif | |||
#define _SUNOS_VTOC_16 | |||
|
|||
#elif defined(__loongarch__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Linux this line is spelled as #elif defined(__loongarch__) && defined(__loongarch_lp64)
. Should here be the same or lp64
is the only option there now and forever?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your suggestion. I have updated the code to be consistent with the Linux version.
It compiles successfully (the porting work is not yet complete, and it has not been tested for normal operation).
Currently, Loongson has not released any high-performance devices using loongarch32 (compared to desktop or server hardware),
so 32-bit loongarch can actually be temporarily disregarded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though the question now is whether __loongarch_lp64
will be defined on FreeBSD. So far is is not. I can see only __loongarch__
. So it feels like we need OS side to stabilize first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
We are attempting to enable support for the LoongArch architecture in FreeBSD. The following error occurred: freebsd/spl/sys/isa_defs.h:288:2: error: "ISA not supported" 288 | #error "ISA not supported" | ^ 1 error generated. *** Error code 1 I referenced the RISC-V and LoongArch for Linux code to create the LoongArch patch. Signed-off-by: Haowu Ge <[email protected]>
37dec38
to
bb5ee50
Compare
Does freebsd-kernel already support loongarch? There is no mailing list for it. Can you provide information about freebsd loongarch support? |
We are working hard to make it a reality. |
Motivation and Context
Attempting to port freebsd to loongarch architecture, compilation error occurred
Description
Added LoongArch related code with reference to RISC-V
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.