Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJS deprecation fixes #17649

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

RxJS deprecation fixes #17649

wants to merge 2 commits into from

Conversation

myabc
Copy link
Contributor

@myabc myabc commented Jan 17, 2025

Ticket

N/A

What are you trying to accomplish?

I came across various RxJS deprecation warnings while working on another bug fix. This PR deals with those potential breaking changes preemptively to make upgrading easier (e.g. the deprecated groupBy function overload will be removed in RxJS 8).

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc marked this pull request as ready for review January 17, 2025 18:22
@myabc myabc added maintenance dependencies Pull requests that update a dependency file labels Jan 17, 2025
@myabc myabc requested a review from oliverguenther January 25, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Development

Successfully merging this pull request may close these issues.

1 participant