Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/59235 notification center activity tab goes into mobile layout even when the browser window is smaller desktop wide #17723

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jjabari-op
Copy link
Collaborator

Ticket

59235

What approach did you choose and why?

  • The activity tab is rendered in three different contexts: wp-full-screen, wp-split-screen, notification-center
  • The mobile breakpoints are different on all of them
  • The implementation before was just optimized for the breakpoints of the wp-full-screen
  • I've now adjusted the JS code to take the context into account when deciding to apply the mobile JS-driven behavior
  • I've added 3 different CSS blocks enabling to control the CSS breakpoint behavior (not elegant, but it's working)
  • Keep in mind that a lot of this will be removed when the primierized wp-tabs will be rolled out to all three bespoken contexts. I've therefore gone for a simple, straight forward "quick-fix" approach here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant