[#60359] Harmonise FeedbackDialog slot naming #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dae6eae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
Renames the `additional_content` slot to `additional_details` to make Feedback Dialog consistent with the newly introduced Danger Confirmation Dialog. ViewComponent defines a `with_SLOT_NAME_content` method for given slots. Using `additional_content` as a slot name results in a `with_additonal_content_content` method being generated - this makes for a poor API for component users.
HDinger
reviewed
Jan 10, 2025
previews/primer/open_project/feedback_dialog_preview/additional_content.html.erb
Show resolved
Hide resolved
myabc
force-pushed
the
feature/60359-update-feedback_dialog-component-slots
branch
from
3e38519 to
a1b641c
Compare
HDinger
force-pushed
the
feature/60359-update-feedback_dialog-component-slots
branch
from
ef42f27 to
d11d468
Compare
HDinger
approved these changes
Jan 10, 2025
Makes naming of Feedback Dialog preview templates consistent with those used by newly introduced Danger Confirmation Dialog.
myabc
force-pushed
the
feature/60359-update-feedback_dialog-component-slots
branch
from
d11d468 to
dae6eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Renames the
additional_contentslot toadditional_detailsto make Feedback Dialog consistent with the newly introduced Danger Confirmation Dialog.ViewComponent defines a
with_SLOT_NAME_contentmethod for given slots. Usingadditional_contentas a slot name results in awith_additonal_content_contentmethod being generated - this makes for a poor API for component users.Screenshots
End users should not see any visual changes.
Integration
This will require update of opf/openproject See PR: opf/openproject#17568
List the issues that this change affects.
Closes https://community.openproject.org/work_packages/60359
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist