🚧 Fix goroutine panic of the rule eval

opsre · Nov 28, 2024 · 557c764 · 557c764
1 parent 612c2bb
commit 557c764
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/alert/eval/eval.go b/alert/eval/eval.go
@@ -64,7 +64,13 @@ func (t *AlertRule) Stop(ruleId string) {
 
 func (t *AlertRule) Eval(ctx context.Context, rule models.AlertRule) {
 	timer := time.NewTicker(time.Second * time.Duration(rule.EvalInterval))
-	defer timer.Stop()
+	defer func() {
+		timer.Stop()
+		if r := recover(); r != nil {
+			logc.Error(t.ctx.Ctx, fmt.Sprintf("Recovered from rule eval goroutine panic: %s", r))
+		}
+	}()
+
 	for {
 		select {
 		case <-timer.C:

diff --git a/pkg/provider/metrics.go b/pkg/provider/metrics.go
@@ -1,6 +1,7 @@
 package provider
 
 import (
+	"fmt"
 	"strconv"
 	"watchAlert/pkg/tools"
 )
@@ -31,7 +32,7 @@ func (m Metrics) GetFingerprint() string {
 	for labelName, labelValue := range m.Metric {
 		sum := tools.HashNew()
 		sum = tools.HashAdd(sum, labelName)
-		sum = tools.HashAdd(sum, labelValue.(string))
+		sum = tools.HashAdd(sum, fmt.Sprintf("%v", labelValue))
 		result ^= sum
 	}