Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

237 sshpublickey and sshpublickeypath should be compatible #247

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

zabdulre
Copy link
Contributor

@zabdulre zabdulre commented Jan 14, 2025

  1. Ensure that if both a sshPublicKey and sshPublicKeyPath are specified, the sshPublicKeyPath is ignored
  2. Document the sshPublicKey and sshPublicKeyPath fields
  3. Remove "some-password-hash" from the password field, it is not a valid default value.

Tested that the sshPublicKeyPath field is handled correctly by specifying the sshPublicKey field in a clusterconfig and setting the sshPublicKeyPath field in defaults.yaml and ensuring only the sshPublicKey is used during a libvirt cluster start.

@zabdulre zabdulre linked an issue Jan 14, 2025 that may be closed by this pull request
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 14, 2025
…ble' of github.com:oracle-cne/ocne into 237-sshpublickey-and-sshpublickeypath-should-be-compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sshPublicKey and sshPublicKeyPath should be compatible
3 participants