generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for empty strings to be used as override, refactor clusterConfig #249
Draft
George-Aeillo
wants to merge
31
commits into
main
Choose a base branch
from
236-empty-string-cannot-be-put-as-an-override-to-the-default-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add ability for empty strings to be used as override, refactor clusterConfig #249
George-Aeillo
wants to merge
31
commits into
main
from
236-empty-string-cannot-be-put-as-an-override-to-the-default-configuration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s started instead of values
…ete debug messages for the CAPI and OLVM provider
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I added the ability to pass in empty strings as overrides to a cluster configuration. This PR also isolates the config structure to only the initial setup of a command, while the actual logic itself only uses the cluster configuration. To accomplish this, the fields in the cluster configuration and config are now pointers to scalar types, rather than the scalar types themselves. These changes were tested on starting and deleting libvirt clusters, CAPI (self managed and non self-managed), image upload, image create, cluster template, and the cluster join command through an in-place upgrade from OCNE 1.7 to 2.0 in an air-gapped environment. I have attached the associated yaml files illustrating how an empty string can be passed through
default.yaml
testConfig.yaml
cluster configuration