Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for empty strings to be used as override, refactor clusterConfig #249

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

George-Aeillo
Copy link
Contributor

In this PR, I added the ability to pass in empty strings as overrides to a cluster configuration. This PR also isolates the config structure to only the initial setup of a command, while the actual logic itself only uses the cluster configuration. To accomplish this, the fields in the cluster configuration and config are now pointers to scalar types, rather than the scalar types themselves. These changes were tested on starting and deleting libvirt clusters, CAPI (self managed and non self-managed), image upload, image create, cluster template, and the cluster join command through an in-place upgrade from OCNE 1.7 to 2.0 in an air-gapped environment. I have attached the associated yaml files illustrating how an empty string can be passed through

default.yaml

name: defaultCluster
registry: private-registry.com
...

testConfig.yaml

name: clusterToOverride
registry: ""
...

cluster configuration

name: clusterToOverride
registry:  ""
...

…ete debug messages for the CAPI and OLVM provider
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty string cannot be put as an override to the default configuration
1 participant