Ignore events from calls not in db #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+285
to
+291
| // Ignore RTCP events for calls that aren't in the database. This can happen | ||
| // if hepipe is just starting up but the telephony service already has calls | ||
| // in progress. | ||
| if (!call) { | ||
| return; | ||
| } | ||
|
|
Comment on lines
+36
to
+39
| if (!message) { | ||
| return; | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hepipe fails to start if the telephony service was already active and processing calls before Hepipe comes online. This is because it's receiving RTCP events for calls that don't exist in it's database.
This PR fixes that by ignore RTCP events if the call doesn't exist. The fix follows the suggestion outlined here:
sipcapture#28