Improve handling of postcode areas #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rank_address reflects the position in the address which is usually lower than what one would expect for a postcode area.
Don't add the postcode again in the list of address details and make sure that the result proper always comes before anything else independently of the address rank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address ranks handle a bit special for postcodes because they tell where the postcode appears in the address display, which is not necessarily related to how much area they cover. So they don't really fit into the usual rank hierarchy. This becomes a problem when computing the "address" of the postcode. If the address is restricted to places with a lower rank address, that is usually not enough. So use the search rank instead which describes the extend of the area. This is already done for postcode points.
Also make sure that the postcode always comes first in the display name.