Fix duplications in search #21701
Open
Fix duplications in search #21701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshcherb
reviewed
Jan 10, 2025
| @@ -304,7 +304,7 @@ public boolean sameSearchResult(SearchResult r1, SearchResult r2) { | |||
| return MapUtils.getDistance(r1.location, r2.location) < similarityRadius; | |||
| } | |||
| } else if (r1.object != null && r2.object != null) { | |||
| return r1.object == r2.object; | |||
| return r1.object.equals(r2.object); | |||
There was a problem hiding this comment.
it's comparision for same object not for similar object, so this is incorrect and we don't support equals on all types
There was a problem hiding this comment.
Classes in this case creates at once in one storage MapPoiTypes: PoiType, PoiCategory, PoiFilter are same.
Other classes creates during searching process: PoiAdditionalCustomFilter, PoiUIFilter, TopIndexFilter can not be same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To issue Brand search results are duplicated after increasing the search radius