Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with GE preset #10235

Merged
merged 3 commits into from
Jan 1, 2025
Merged

Sync with GE preset #10235

merged 3 commits into from
Jan 1, 2025

Conversation

balsoft
Copy link
Contributor

@balsoft balsoft commented Dec 19, 2024

Syncs with https://github.com/komachi/josm-ge-preset, mostly adding wikidata tags

Copy link
Collaborator

@Cj-Malone Cj-Malone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a quick glance, the biggest thing is operator:wikidata without operator. But also I don't think we should be encouraging operator:wikidata to be a copy of brand:wikidata.

@balsoft
Copy link
Contributor Author

balsoft commented Dec 19, 2024

@Cj-Malone noted. Should I remove all operator:wikidata or only the ones where there's no operator?

@balsoft
Copy link
Contributor Author

balsoft commented Dec 19, 2024

@Cj-Malone done, please squash before merging though

@balsoft balsoft requested a review from Cj-Malone December 19, 2024 14:34
@Snowysauce
Copy link
Collaborator

I agree with both points made by @Cj-Malone, and I have a couple additional reservations of my own. The first is the addition of drink:* tags to an entry in shop/alcohol: I'm aware that there are two other entries with them, but tags like those are generally outside of our scope (see #8270 (review)). The other reservation is the seemingly random change to amenity/police: the removed line is necessary for compliance with https://wiki.openstreetmap.org/wiki/Multilingual_names.

@balsoft
Copy link
Contributor Author

balsoft commented Dec 23, 2024

@Snowysauce agreed on both counts, fixed.

Syncs with https://github.com/komachi/josm-ge-preset, mostly adding
wikidata tags
@balsoft balsoft force-pushed the sync-with-ge-preset branch from 65fac1a to 870ceec Compare December 23, 2024 10:12
Copy link
Collaborator

@Cj-Malone Cj-Malone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not to fond of some of this, removing name, flip flopping on payment:*, adding operator which is the same as brand. However, lets go for now.

@Cj-Malone Cj-Malone merged commit 029b317 into osmlab:main Jan 1, 2025
3 checks passed
@balsoft
Copy link
Contributor Author

balsoft commented Jan 1, 2025

@Cj-Malone thanks! I'll see if I can align our preset more with your requirements vis-à-vis operator:wikidata vs brand:wikidata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants