-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with GE preset #10235
Sync with GE preset #10235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a quick glance, the biggest thing is operator:wikidata
without operator
. But also I don't think we should be encouraging operator:wikidata
to be a copy of brand:wikidata
.
@Cj-Malone noted. Should I remove all |
@Cj-Malone done, please squash before merging though |
I agree with both points made by @Cj-Malone, and I have a couple additional reservations of my own. The first is the addition of |
@Snowysauce agreed on both counts, fixed. |
Syncs with https://github.com/komachi/josm-ge-preset, mostly adding wikidata tags
65fac1a
to
870ceec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not to fond of some of this, removing name
, flip flopping on payment:*
, adding operator
which is the same as brand
. However, lets go for now.
@Cj-Malone thanks! I'll see if I can align our preset more with your requirements vis-à-vis |
Syncs with https://github.com/komachi/josm-ge-preset, mostly adding wikidata tags