fix(bunfig): fix and test preloads #16329
Draft
+199
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
DonIsaac
force-pushed
the
don/fix/bunfig-preload
branch
from
46741e1 to
6afdbbc
Compare
DonIsaac
force-pushed
the
01-10-fix_toml_cursor_pos_for_duplicate_key_errors
branch
from
9f6b1e4 to
0d6749a
Compare
DonIsaac
force-pushed
the
don/fix/bunfig-preload
branch
from
6afdbbc to
cd45010
Compare
Base automatically changed from
01-10-fix_toml_cursor_pos_for_duplicate_key_errors
to
main
January 11, 2025 07:13
DonIsaac
commented
Jan 14, 2025
| expect(code).toBe(0); | ||
| }); | ||
|
|
||
| // FIXME: relative paths are being resolved to cwd, not the file's directory |
DonIsaac
commented
Jan 14, 2025
| // | ||
| "--preload ./preload3.ts", | ||
| "--preload=./preload3.ts", | ||
| // FIXME: Tests are failing due to active bugs |
There was a problem hiding this comment.
These are bugs. The last pair suffers the same problem as --config. At the very least, run --preload=./file.ts should be allowed.
DonIsaac
commented
Jan 14, 2025
| describe("Given a `bunfig.toml` file with a relative path without a leading './'", () => { | ||
| const dir = fixturePath("relative"); | ||
|
|
||
| // FIXME: currently treaded as an import to an external package |
DonIsaac
force-pushed
the
don/fix/bunfig-preload
branch
from
43da5d5 to
af01c9d
Compare
DonIsaac
force-pushed
the
don/fix/bunfig-preload
branch
from
af01c9d to
58d60bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preloads are currently problematic (#16289, etc). I'm adding a bunch of tests for them (in this PR) and fixing what I find (in upstack PRs)
Please review the tests I've added and give feedback on expected behavior.
How did you verify your code works?
These are all test changes.