fix more node:stream #16385

nektro · 2025-01-13T23:39:02Z

No description provided.

robobun · 2025-01-13T23:39:11Z

^{Updated 6:27 PM PT - Jan 14th, 2025}

❌ @nektro, your commit 79494e8 has 10 failures in #9597:

test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 22.04 x64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🐧 3.20 x64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http-zero-length-write.js - code 1 on 🍎 14 aarch64
test/js/node/http/node-http.test.ts - 1 failing on 🪟 2019 x64-baseline
test/js/node/http/node-http.test.ts - 1 failing on 🐧 22.04 aarch64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 24.04 aarch64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 12 aarch64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 20.04 aarch64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 3.20 aarch64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/js/node/http/node-http.test.ts - 1 failing on 🐧 12 x64-baseline
test/js/node/http/node-http.test.ts - 1 failing on 🍎 14 x64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/js/node/http/node-http.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/js/node/http/node-http.test.ts - 1 failing on 🐧 24.04 x64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 20.04 x64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 12 x64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 22.04 x64
test/js/node/http/node-http.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/js/node/http/node-http.test.ts - 1 failing on 🐧 3.20 x64
test/js/node/http/node-http.test.ts - 1 failing on 🍎 13 x64
test/js/node/http/node-http.test.ts - 1 failing on 🪟 2019 x64
test/js/node/http/node-http.test.ts - 1 failing on 🍎 13 aarch64
test/js/node/http/node-http.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/util/inspect-error.test.js - 3 failing on 🪟 2019 x64-baseline
test/js/bun/util/inspect-error.test.js - 3 failing on 🪟 2019 x64
test/js/bun/util/inspect-error.test.js - 3 failing on 🍎 14 x64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 12 aarch64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 22.04 aarch64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 20.04 aarch64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 24.04 aarch64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 3.20 aarch64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 24.04 x64-baseline
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 22.04 x64-baseline
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 20.04 x64-baseline
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 12 x64-baseline
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 12 x64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 24.04 x64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 20.04 x64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 22.04 x64
test/js/bun/util/inspect-error.test.js - 3 failing on 🍎 13 x64
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 3.20 x64-baseline
test/js/bun/util/inspect-error.test.js - 3 failing on 🐧 3.20 x64
test/js/bun/util/inspect-error.test.js - 3 failing on 🍎 13 aarch64
test/js/bun/util/inspect-error.test.js - 3 failing on 🍎 14 aarch64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🪟 2019 x64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 24.04 aarch64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 22.04 aarch64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 20.04 aarch64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 12 aarch64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 3.20 aarch64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 12 x64-baseline
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 22.04 x64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 24.04 x64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 20.04 x64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 12 x64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🐧 3.20 x64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🍎 13 aarch64
test/js/node/test/parallel/test-stream-iterator-helpers-test262-tests.mjs - timeout on 🍎 14 aarch64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🪟 2019 x64-baseline
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🪟 2019 x64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 12 aarch64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 20.04 aarch64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 22.04 aarch64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 24.04 aarch64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 3.20 aarch64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🍎 14 x64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 12 x64-baseline
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 12 x64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 24.04 x64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 22.04 x64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 20.04 x64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 3.20 x64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🍎 13 x64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🍎 13 aarch64
test/js/web/fetch/client-fetch.test.ts - 1 failing on 🍎 14 aarch64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🪟 2019 x64-baseline
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 22.04 aarch64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 20.04 aarch64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 24.04 aarch64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 12 aarch64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 22.04 x64-baseline
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 12 x64-baseline
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 3.20 aarch64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 12 x64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 24.04 x64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 24.04 x64-baseline
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 20.04 x64-baseline
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 20.04 x64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 22.04 x64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 3.20 x64-baseline
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🐧 3.20 x64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🍎 13 aarch64
test/js/node/test/parallel/test-http2-compat-serverresponse-drain.js - code 1 on 🍎 14 aarch64
test/js/bun/test/stack.test.ts - 1 failing on 🪟 2019 x64-baseline
test/js/bun/test/stack.test.ts - 1 failing on 🪟 2019 x64
test/js/bun/test/stack.test.ts - 1 failing on 🍎 14 x64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 20.04 aarch64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 22.04 aarch64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 24.04 aarch64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 12 aarch64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 3.20 aarch64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 24.04 x64-baseline
test/js/bun/test/stack.test.ts - 1 failing on 🐧 22.04 x64-baseline
test/js/bun/test/stack.test.ts - 1 failing on 🐧 12 x64-baseline
test/js/bun/test/stack.test.ts - 1 failing on 🐧 20.04 x64-baseline
test/js/bun/test/stack.test.ts - 1 failing on 🐧 24.04 x64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 22.04 x64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 20.04 x64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 12 x64
test/js/bun/test/stack.test.ts - 1 failing on 🍎 13 x64
test/js/bun/test/stack.test.ts - 1 failing on 🐧 3.20 x64-baseline
test/js/bun/test/stack.test.ts - 1 failing on 🐧 3.20 x64
test/js/bun/test/stack.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/test/stack.test.ts - 1 failing on 🍎 14 aarch64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🪟 2019 x64-baseline
test/cli/install/bun-workspaces.test.ts - 8 failing on 🍎 14 x64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🪟 2019 x64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🍎 13 x64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 20.04 aarch64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 12 aarch64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 22.04 aarch64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 24.04 aarch64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 3.20 aarch64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 22.04 x64-baseline
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 20.04 x64-baseline
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 24.04 x64-baseline
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 12 x64-baseline
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 24.04 x64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 22.04 x64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 12 x64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 20.04 x64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 3.20 x64-baseline
test/cli/install/bun-workspaces.test.ts - 8 failing on 🐧 3.20 x64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🍎 13 aarch64
test/cli/install/bun-workspaces.test.ts - 8 failing on 🍎 14 aarch64

🧪 try this PR locally:

bunx bun-pr 16385

nektro added 30 commits January 6, 2025 16:32

fix test-streams-highwatermark.js

4b88b3c

fix _stream_duplex

fed57a7

fix _stream_passthrough

2005b10

fix _stream_readable

9f05404

fix _stream_transform

ecf9fbc

fix _stream_writable

32cb082

add internal/streams/state

2a50e9b

remove require_validators

c99a2be

add internal/streams/utils

259bffc

add internal/streams/destroy

cb8468d

add internal/streams/end-of-stream

a330d8e

add internal/streams/legacy

699a38d

add internal/streams/from

909f405

add internal/streams/add-abort-signal

6c9dd58

add internal/streams/writable

3fc3236

add internal/streams/readable

7981162

add internal/streams/duplex

04d9ead

add internal/streams/duplexpair

226785c

add internal/streams/transform

2e8ec4d

add internal/streams/passthrough

eea89a5

add internal/streams/lazy_transform

feeb39d

add internal/streams/pipeline

8fd2ec0

add internal/streams/compose

035ab03

add internal/streams/operators

22e0851

remove internal/streams/duplexify

b09bf05

add internal/streams/duplexify

0e340cc

fixes

c7b1e05

new tests

0655935

more tests

b09b008

add 'bytes' method back to node:stream/consumers

3145af9

nektro added 7 commits January 10, 2025 19:51

fix more tests

650bdc4

remove ERR_OUT_OF_RANGE from internal/errors

95d29b5

make internal/errors smaller

21581bd

dont expose InternalPromise to outside world

68e5aac

tidy scripts/check-node-all.sh

331625c

Merge remote-tracking branch 'origin/main' into nektro-patch-38133

71e2328

use $inheritsReadableStream instead of $isReadableStream here

b9fd28e

nektro added 9 commits January 13, 2025 16:24

move NativeWritable to its own file

5da05d4

fix merge error

60844b0

remove jsdoc comments

04408b9

add missing toString() method on NodeError

9e9afb9

field name cleanup in ZigException

5b99a07

missing .$call

af12057

add NativeReadable back in

842b5dc

some fixes

0fdf927

some fixes

79494e8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix more node:stream #16385

fix more node:stream #16385

nektro commented Jan 13, 2025

robobun commented Jan 13, 2025 •

edited

Loading

fix more node:stream #16385

Are you sure you want to change the base?

fix more node:stream #16385

Conversation

nektro commented Jan 13, 2025

robobun commented Jan 13, 2025 • edited Loading

robobun commented Jan 13, 2025 •

edited

Loading