Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] test(node/url): add remaining node:test parallel cases #16404

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 15, 2025

What does this PR do?

Ports remaining node:url parallel test cases.

Checklist

  • test-url-format-invalid-input
  • test-url-parse-invalid-input
  • test-url-parse-query
  • test-url-relative
  • test-url-is-url-internal tests node internals we can safely skip
  • test-url-pathtofileurl
  • test-url-fileurltopath

How did you verify your code works?

This pr, shockingly, contains new test cases

@robobun
Copy link

robobun commented Jan 15, 2025

Updated 10:14 PM PT - Jan 14th, 2025

@DonIsaac, your commit 6e496c6 has 3 failures in #9623:


🧪   try this PR locally:

bunx bun-pr 16404

@DonIsaac DonIsaac changed the title test(node/url): test-url-relative [WIP] test(node/url): test-url-relative Jan 15, 2025
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DonIsaac DonIsaac changed the title [WIP] test(node/url): test-url-relative [WIP] test(node/url): add remaining node:test parallel cases Jan 15, 2025
@DonIsaac DonIsaac force-pushed the don/test/node-url branch 4 times, most recently from 3433e0b to d815d07 Compare January 15, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants