Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig: else branch is implicitly void #16406

Merged
merged 1 commit into from
Jan 15, 2025
Merged

zig: else branch is implicitly void #16406

merged 1 commit into from
Jan 15, 2025

Conversation

nektro
Copy link
Member

@nektro nektro commented Jan 15, 2025

learned about this recently, still not decided on how i feel about whether its a net positive or negative to readability
what do you think @paperclover @190n ?

@robobun
Copy link

robobun commented Jan 15, 2025

Updated 9:32 PM PT - Jan 14th, 2025

@nektro, your commit c4b5d50 has 2 failures in #9617:


🧪   try this PR locally:

bunx bun-pr 16406

Copy link
Member

@paperclover paperclover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i use this all the time. @DonIsaac should make this a check in zlint

@nektro nektro marked this pull request as ready for review January 15, 2025 05:54
@nektro nektro merged commit 68089a0 into main Jan 15, 2025
51 of 69 checks passed
@nektro nektro deleted the nektro-patch-20585 branch January 15, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants