-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1-subgraph
clean-up
#26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurka-o
force-pushed
the
arthurka/bac-122-v1-subgraph-clean-up
branch
from
August 14, 2024 13:18
6e332a7
to
43bc13e
Compare
- Calculate `initialCollateral` without external calls Extracted how much user sends OVL to the contract, substract `transferFee` and get `initialCollateral` - Fix tests
- Replace `currentOi` with `oiUnwound` - Remove `currentDebt`, `isLong`, `collateral`, and `value`
arthurka-o
force-pushed
the
arthurka/bac-122-v1-subgraph-clean-up
branch
from
August 22, 2024 13:37
4c2b6d6
to
7918bab
Compare
Also had to revert `Build`, `Unwind`, and `Liquidate`
Check compatibility with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/autonomysoftware/issue/BAC-122/v1-subgraph-clean-up
Changes in schema:
Build
:currentOi
is removed (we already haveposition.initialOi
)currentDebt
is removed (we already haveposition.initialDebt
)isLong
is removed (we already haveposition.isLong
)collateral
is removed (we already haveposition.initialCollateral
)value
is removed (not used as far as we know)Unwind
:currentOi
is renamed tooiUnwound
- "amount of oi unwound"currentDebt
is removed (we already haveposition.currentDebt
)isLong
is removed (same asBuild
)collateral
is removed (didn't make sense, was always 0)value
is removed (didn't make sense, was always 0)Liquidate
:currentOi
is removed (we already haveposition.currentOi
)currentDebt
is removed (same asUnwind
)isLong
is removed (same asBuild
)collateral
is removed (same asUnwind
)value
is removed (same asUnwind
)