refactor

owncloud · Nov 22, 2023 · 9aeef58 · 9aeef58
1 parent 7fedf38
commit 9aeef58
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/test/gui/shared/scripts/helpers/SetupClientHelper.py b/test/gui/shared/scripts/helpers/SetupClientHelper.py
@@ -25,7 +25,7 @@ def getClientDetails(context):
         'user': '',
         'password': '',
         'sync_folder': '',
-        'auth_type': 'basic',  # basic, oauth2 or oidc (used to determine the auth method)
+        'oauth': False,
     }
     for row in context.table[0:]:
         row[1] = substituteInLineCodes(row[1])

diff --git a/test/gui/shared/scripts/pageObjects/AccountConnectionWizard.py b/test/gui/shared/scripts/pageObjects/AccountConnectionWizard.py
@@ -170,10 +170,10 @@ def acceptCertificate():
         )
 
     @staticmethod
-    def addUserCreds(username, password, auth_type=None):
+    def addUserCreds(username, password, oauth=False):
         if get_config('ocis'):
             AccountConnectionWizard.oidcLogin(username, password)
-        elif auth_type == 'oauth2':
+        elif oauth:
             AccountConnectionWizard.oauthLogin(username, password)
         else:
             AccountConnectionWizard.basicLogin(username, password)
@@ -264,7 +264,7 @@ def addAccountInformation(account_details):
             AccountConnectionWizard.addUserCreds(
                 account_details['user'],
                 account_details['password'],
-                account_details['auth_type'],
+                account_details['oauth'],
             )
         sync_path = ''
         if account_details['sync_folder']:

diff --git a/test/gui/shared/steps/account_context.py b/test/gui/shared/steps/account_context.py
@@ -247,7 +247,7 @@ def step(context):
 @When('the user adds the following oauth2 account:')
 def step(context):
     account_details = getClientDetails(context)
-    account_details.update({'auth_type': "oauth2"})
+    account_details.update({'oauth': True})
     AccountConnectionWizard.addAccount(account_details)
     # wait for files to sync
     waitForInitialSyncToComplete(getResourcePath('/', account_details["user"]))