Fix reaching unreachable code

owncloud · Nov 8, 2023 · c10fe65 · c10fe65
1 parent 09a87a9
commit c10fe65
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/common/checksums.cpp b/src/common/checksums.cpp
@@ -227,6 +227,7 @@ ComputeChecksum::~ComputeChecksum()
 
 void ComputeChecksum::setChecksumType(CheckSums::Algorithm type)
 {
+    Q_ASSERT(type != CheckSums::Algorithm::NONE && type != CheckSums::Algorithm::PARSE_ERROR);
     _checksumType = type;
 }
 

diff --git a/src/gui/folder.cpp b/src/gui/folder.cpp
@@ -701,7 +701,7 @@ void Folder::slotWatchedPathsChanged(const QSet<QString> &paths, ChangeReason re
                 Q_ASSERT([&] {
                     Q_ASSERT(record.isValid());
                     // we don't intend to burn to many cpu cycles so limit this check on small files
-                    if (!record.isVirtualFile() && record._fileSize < static_cast<qint64>(1_mb)) {
+                    if (!record.isVirtualFile() && record._fileSize < static_cast<qint64>(1_mb) && !record._checksumHeader.isEmpty()) {
                         const auto header = ChecksumHeader::parseChecksumHeader(record._checksumHeader);
                         auto *compute = new ComputeChecksum(this);
                         compute->setChecksumType(header.type());
-Original file line number
+Diff line change
@@ Expand Up / @@ -227,6 +227,7 @@ ComputeChecksum::~ComputeChecksum() @@
     void ComputeChecksum::setChecksumType(CheckSums::Algorithm type)
     {
+        Q_ASSERT(type != CheckSums::Algorithm::NONE && type != CheckSums::Algorithm::PARSE_ERROR);
         _checksumType = type;
     }
@@ Expand Down @@