Fix possible crash when starting shell integration #11288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
approved these changes
Oct 13, 2023
TheOneRing
previously requested changes
Oct 13, 2023
The shell integration was started while the folder manager was being instantiated. It could happen that callbacks came in when this was not yet completed, resulting in a crash when calling back into the (incomplete) folder manager. Now shell integration is started after all other startup work has been completed. Fixes: #11280
erikjv
force-pushed
the
work/fix-socketapi-crash
branch
from
cdbfd51 to
ece3eec
Compare
fmoc
previously approved these changes
Oct 16, 2023
|
Kudos, SonarCloud Quality Gate passed! |
fmoc
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell integration was started while the folder manager was being instantiated. It could happen that callbacks came in when this was not yet completed, resulting in a crash when calling back into the (incomplete) folder manager.
Now shell integration is started after all other startup work has been completed.
Fixes: #11280