Fix current CPU architecture detection with rosetta2 #11376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoc
force-pushed
the
work/macos-rosetta2-currentArch
branch
from
1c88416 to
83d88a8
Compare
2 tasks
TheOneRing
reviewed
Nov 17, 2023
|
If you really want to you can enforce new lines with // |
TheOneRing
approved these changes
Nov 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a syscall to properly detect whether the application is running inside of macOS's rosetta2 emulator. It replaces uses of
QSysInfo::currentCpuArchitecture()with a custom in our code.It further extends the about dialog to show the detected build and CPU architectures.
This is a preparation for #10757.
Please note that the formatting changes are forced by clang-format. I'm not a fan of them.