Rewrite Folder Status in qml #11491
Merged
Rewrite Folder Status in qml #11491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheOneRing
commented
Jan 19, 2024
•
TheOneRing
commented
2 tasks
TheOneRing
force-pushed
the
work/selecitve_sync
branch
6 times, most recently
from
8181ac0 to
e3a2213
Compare
TheOneRing
force-pushed
the
work/selecitve_sync
branch
2 times, most recently
from
5c85f3d to
1ef3248
Compare
TheOneRing
force-pushed
the
work/selecitve_sync
branch
5 times, most recently
from
c4f8b14 to
367185b
Compare
TheOneRing
force-pushed
the
work/selecitve_sync
branch
4 times, most recently
from
d9db579 to
adac249
Compare
TheOneRing
force-pushed
the
work/selecitve_sync
branch
6 times, most recently
from
f663116 to
17b5dfb
Compare
TheOneRing
changed the title
TheOneRing
force-pushed
the
work/selecitve_sync
branch
from
17b5dfb to
1eeef49
Compare
2 tasks
TheOneRing
changed the title
TheOneRing
commented
Mar 15, 2024
| } | ||
| case Columns::FolderImageUrl: | ||
| if (f->accountState()->supportsSpaces()) { | ||
| // TODO: the url hast random parts to enforce a reload |
There was a problem hiding this comment.
Using the random number is a hack.
In theory, we could directly use a http url.
However, we would need to provide a new networkaccess manager as the qml context runs in a different thread.
Our current nam, used for authentication and logging, is currently not designed in a way that really supports multiple instances.
client/src/libsync/creds/httpcredentials.cpp
Line 134 in 1eeef49
TheOneRing
force-pushed
the
work/selecitve_sync
branch
4 times, most recently
from
82cd20d to
44bd88e
Compare
This prepares the work on the improved accessibility Issue: #11527
erikjv
approved these changes
Mar 15, 2024
|
Tested with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.