Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for creation of a spaces folder in a spaces root #11532

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Feb 23, 2024

Fixes: #11516

@erikjv erikjv requested a review from TheOneRing February 23, 2024 15:16
@erikjv erikjv self-assigned this Feb 23, 2024
@erikjv erikjv marked this pull request as draft February 23, 2024 15:17
src/gui/folderman.cpp Outdated Show resolved Hide resolved
src/gui/folderman.cpp Outdated Show resolved Hide resolved
test/testfolderman.cpp Show resolved Hide resolved
src/gui/folderman.cpp Show resolved Hide resolved
@erikjv erikjv force-pushed the work/fix-spaces-folder-in-spaces-root branch 2 times, most recently from 3f1d119 to 422f793 Compare March 14, 2024 17:09
@erikjv erikjv requested a review from TheOneRing March 15, 2024 13:56
@erikjv erikjv marked this pull request as ready for review March 15, 2024 14:32
src/gui/folderman.cpp Show resolved Hide resolved
src/gui/folderman.cpp Outdated Show resolved Hide resolved
src/gui/folderwizard/folderwizardlocalpath.cpp Outdated Show resolved Hide resolved
test/testfolderman.cpp Show resolved Hide resolved
@erikjv erikjv force-pushed the work/fix-spaces-folder-in-spaces-root branch from 6d23434 to f241164 Compare March 20, 2024 12:57
@erikjv erikjv requested a review from TheOneRing March 20, 2024 12:59
Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@erikjv erikjv force-pushed the work/fix-spaces-folder-in-spaces-root branch from f241164 to 1dd9505 Compare March 22, 2024 15:26
@erikjv erikjv force-pushed the work/fix-spaces-folder-in-spaces-root branch from 1dd9505 to 72aaf67 Compare March 26, 2024 10:53
@TheOneRing TheOneRing merged commit 6c7e7ef into master Mar 26, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/fix-spaces-folder-in-spaces-root branch March 26, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: getDirectorySyncRootMarking prevents adding spaces to sync folder
2 participants