Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui-tests][full-ci] check keyring before starting client #12028

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jan 7, 2025

Added keyring check before starting client. The check is done with multiple retries until a timeout is reached.

Fixes #11883

THe problem with the mentioned issue was that sometimes the keyring service gets killed or disconnected in the middle of the test execution.

@saw-jan saw-jan added the QA:team label Jan 7, 2025
@saw-jan saw-jan self-assigned this Jan 7, 2025
@saw-jan saw-jan changed the title [DO-NOT-MERGE] ci: check keyring fixed image [DO-NOT-MERGE][full-ci]: check keyring fixed image Jan 7, 2025
@saw-jan saw-jan force-pushed the tests/check-keyring-fix branch 8 times, most recently from b34a0ad to 4e6f330 Compare January 10, 2025 06:04
@saw-jan saw-jan force-pushed the tests/check-keyring-fix branch from 2caa979 to 825a956 Compare January 14, 2025 04:09
@saw-jan saw-jan changed the title [DO-NOT-MERGE][full-ci]: check keyring fixed image [gui-tests][full-ci] check keyring before starting client Jan 14, 2025
@saw-jan saw-jan marked this pull request as ready for review January 14, 2025 04:12
Copy link
Contributor

@ishabaral ishabaral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit 4670d13 into master Jan 15, 2025
6 checks passed
@saw-jan saw-jan deleted the tests/check-keyring-fix branch January 15, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] GUI tests sometime fails due to the system keyring dialog
2 participants