Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove per service store settings #815

Merged
merged 1 commit into from
Nov 25, 2024
Merged

remove per service store settings #815

merged 1 commit into from
Nov 25, 2024

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 25, 2024 •
edited
Loading

Description

Remove per service store settings.

I think this is more of a footgun nowadays and should be removed. Please note that we don't have this setting for the caches, too.

Related Issue

Motivation and Context

How Has This Been Tested?

  • not tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@wkloucek wkloucek requested a review from d7oc November 25, 2024 14:06
@wkloucek wkloucek merged commit 555355b into owncloud:main Nov 25, 2024
1 check passed
@wkloucek wkloucek deleted the remove-per-service-store-settings branch November 25, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7oc d7oc d7oc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @d7oc