Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter): rule no-restricted-imports support missing options #8076

Merged
merged 10 commits into from
Jan 18, 2025
Merged

fix(linter): rule no-restricted-imports support missing options #8076

merged 10 commits into from
Jan 18, 2025
+659 −367

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Dec 23, 2024 •
edited
Loading

The regex property is used to specify the regex patterns for restricting modules.
Note: regex cannot be used in combination with group.

https://eslint.org/docs/latest/rules/no-restricted-imports#regex

This option allows you to use regex patterns to restrict import names:

https://eslint.org/docs/latest/rules/no-restricted-imports#importnamepattern

This is a string option. Inverse of importNamePattern, this option allows imports that matches the specified regex pattern. So it restricts all imports from a module, except specified allowed patterns.
Note: allowImportNamePattern cannot be used in combination with importNames, importNamePattern or allowImportNames.

https://eslint.org/docs/latest/rules/no-restricted-imports#allowimportnamepattern

Needed to install regress to support JS Sntax like Lookaheads and Lookbehinds

Next Goals:

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 23, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Dec 23, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 23, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8076 will not alter performance

Comparing Sysix:fix-linter-no-restricted-imports-regex-option (d6c1674) with main (f367a16)

Summary

✅ 29 untouched benchmarks

@Sysix Sysix marked this pull request as ready for review December 23, 2024 15:21
@Sysix Sysix changed the title fix(linter): rule no-restricted-imports support regex option inside patterns fix(linter): rule no-restricted-imports support regex & importNamePattern option inside patterns Dec 23, 2024
@Sysix Sysix marked this pull request as draft December 23, 2024 17:09
@Sysix Sysix changed the title fix(linter): rule no-restricted-imports support regex & importNamePattern option inside patterns fix(linter): rule no-restricted-imports support missing options Dec 23, 2024
@Sysix Sysix marked this pull request as ready for review December 23, 2024 17:24
Boshen
Boshen reviewed Dec 25, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@Sysix Sysix mentioned this pull request Dec 25, 2024
Open
@Sysix Sysix requested a review from Boshen December 25, 2024 15:13
@Sysix
Copy link
Collaborator Author

Sysix commented Dec 31, 2024 •
edited
Loading

/ping

#8113 is almost ready, only two or three missmatches found missmatched spans found

camchenry
camchenry reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Let's use is_match instead of find().is_some(), but otherwise this looks good!

crates/oxc_linter/src/rules/eslint/no_restricted_imports.rs Show resolved Hide resolved
crates/oxc_linter/src/rules/eslint/no_restricted_imports.rs Outdated Show resolved Hide resolved
crates/oxc_linter/src/rules/eslint/no_restricted_imports.rs Show resolved Hide resolved
@Sysix Sysix requested a review from camchenry January 3, 2025 15:40
@Sysix
Copy link
Collaborator Author

Sysix commented Jan 9, 2025

@Boshen only your approval is missing :)

@Boshen Boshen merged commit 41f2070 into oxc-project:main Jan 18, 2025
26 checks passed
@oxc-bot oxc-bot mentioned this pull request Jan 19, 2025
Merged
Boshen added a commit that referenced this pull request Jan 19, 2025
@oxc-bot @Boshen
release(oxlint): v0.15.7 (#8592)
66c8720 
## [0.15.7] - 2025-01-19

### Features

- 01ac773 linter: Support `ignoreTypeOfTestName` for `jest/valid-title`
(#8589) (dalaoshu)
- 538b24a linter: Format the configuration documentation correctly
(#8583) (Tapan Prakash)
- 7ab14cc linter: Add more Vitest compatible Jest rules (#8445) (Anson
Heung)
- d178360 linter: Implement `eslint/prefer-promise-reject-errors`
(#8254) (tbashiyy)
- 4ac2e99 oxlint: Implement `--init` cli option (#8453) (Tapan Prakash)

### Bug Fixes

- 855c839 codegen: Shorthand assignment target identifier consider
mangled names (#8536) (Boshen)
- c15af02 linter: False positive in `eslint/no-lone-blocks` (#8587)
(dalaoshu)
- 41f2070 linter: Rule `no-restricted-imports` support missing options
(#8076) (Alexander S.)
- 869bc73 linter: Enhance `default_param_last` rule to handle optional
parameters (#8563) (Tapan Prakash)
- c6260c2 linter: Support rest params for `prefer_promise_reject_errors`
(#8468) (Yuichiro Yamashita)
- 2be1e82 linter/no-unused-vars: False positives when variable and type
have same name (#8465) (Dunqing)

### Performance

- 250bbd1 linter/react-exhaustive-deps: Use stack of `AstType`s instead
of `AstKind`s (#8522) (overlookmotel)

### Refactor

- 40f5165 linter: Improve `eslint/no-lone-blocks` (#8588) (dalaoshu)
- b4c87e2 linter: Move DiagnosticsReporters to oxlint (#8454) (Alexander
S.)
- bf00f82 linter: Move rule `prefer-each` from vitest to jest +
remapping (#8448) (Alexander S.)
- 8dd0013 linter/consistent-function-scoping: Remove `Visit::enter_node`
usage (#8538) (overlookmotel)
- 30c0689 linter/no-map-spread: Remove `Visit::enter_node` usage (#8537)
(overlookmotel)
- b5ed58e span: All methods take owned `Span` (#8297) (overlookmotel)

### Styling

- 3789d2f linter/react-exhaustive-deps: Fix indentation (#8520)
(overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

@camchenry camchenry camchenry approved these changes

@Boshen Boshen Awaiting requested review from Boshen

Assignees
No one assigned
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sysix @Boshen @camchenry @camc314