fix(isolated-declarations): unexpected error when global Symbol as property key
#8475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-isolated-declarations
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8475 will not alter performanceComparing Summary
|
Merge activity
|
Boshen
force-pushed
the
01-14-fix_isolated-declarations_unexpected_error_when_global_symbol_as_property_key
branch
from
c2ea8d0 to
7252cb0
Compare
graphite-app
bot
deleted the
01-14-fix_isolated-declarations_unexpected_error_when_global_symbol_as_property_key
branch
Boshen
added a commit
that referenced
this pull request
Jan 14, 2025
## [0.46.0] - 2025-01-14 - 7eb6ccd ast: [**BREAKING**] Remove unused and not useful `ContentHash` (#8483) (Boshen) ### Features - 8accfef minifier: Minify `var x; void x` -> `void 0` (#8466) (Boshen) - 870a583 minifier: Fold `false['toString']` (#8447) (Boshen) - 4ad695d napi/minify: Implement napi (#8478) (Boshen) - 9d550aa span: Add `Atom::r#static` (#8479) (_Kerman) ### Bug Fixes - 4071878 isolated-declarations: Retain `declare` declarations when they are exported (#8477) (Dunqing) - 7ee7634 isolated-declarations: Import statement disappears when import binding is referenced in nested `typeof` (#8476) (Dunqing) - 7252cb0 isolated-declarations: Unexpected error when global `Symbol` as property key (#8475) (Dunqing) - 4c6675c minifier: Do not convert while to fors in DCE (#8484) (Boshen) - 1d6e84d minifier: Fix incorrect `null.toString()` and `1n.toString()` (#8464) (Boshen) - 25d4bf9 minifier: Remove usage of empty spans (#8462) (Boshen) - dd64340 minifier: Keep `return undefined` in async generator function (#8439) (Boshen) - c444de8 transformer/arrow-functions: Transform `this` and `super` incorrectly in async arrow function (#8435) (Dunqing) - 270245f transformer/typescript: Correct the semantic for TSImportEqualsDeclaration transformation (#8463) (Dunqing) - 2a400d6 transformer/typescript: Retain TSImportEqualsDeclaration when it is exported (Dunqing) - ab694b0 transformer/typescript: Retain `TSImportEqualsDeclaration` in `namespace` when its binding has been referenced or `onlyRemoveTypeImports` is true (#8458) (Dunqing) ### Performance - 7a8200c mangler: Allocate base54 name without heap allocation (#8472) (Boshen) - 31dac22 mangler: Allocate data in arena (#8471) (Boshen) - 8fc238a minifier: Merge `Normalize` and `RemoveSyntax` pass (#8467) (Boshen) - 372eb09 minifier: Preallocate mangler's semantic data (#8451) (Boshen) ### Refactor - 6e64eef codegen: Remove `match_expression!` (#8450) (Boshen) - de5b288 span: Rename `Atom::new_const` method (#8480) (overlookmotel) - c83ce5c transformer/typescript: Improve transforming namespace (#8459) (Dunqing) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #8469
No support to report errors for non-global
Symbolyet, it is hard for the current architecture.