Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lexer): finish_next only clear kind and flags #8576

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

overlookmotel
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Jan 18, 2025

CodSpeed Performance Report

Merging #8576 will not alter performance

Comparing 01-18-perf_lexer_finish_next_only_clear_kind_and_flags_ (a5e9929) with main (63eb298)

Summary

✅ 32 untouched benchmarks

@overlookmotel
Copy link
Contributor Author

What the hell? +2% on lexer, but -1% on parser benchmarks!

@Boshen Boshen changed the base branch from 01-04-perf_span_compare_span_s_as_single_u64_s to graphite-base/8576 January 18, 2025 01:49
@Boshen Boshen force-pushed the graphite-base/8576 branch from 979be1a to 63eb298 Compare January 18, 2025 02:11
@Boshen Boshen force-pushed the 01-18-perf_lexer_finish_next_only_clear_kind_and_flags_ branch from f459841 to b8c65d2 Compare January 18, 2025 02:11
@Boshen Boshen changed the base branch from graphite-base/8576 to main January 18, 2025 02:12
@Boshen Boshen force-pushed the 01-18-perf_lexer_finish_next_only_clear_kind_and_flags_ branch from b8c65d2 to a5e9929 Compare January 18, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant