Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minifier): fix dce shadowed undefined #8582

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 18, 2025

No description provided.

Copy link

graphite-app bot commented Jan 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-minifier Area - Minifier C-bug Category - Bug labels Jan 18, 2025
Copy link

codspeed-hq bot commented Jan 18, 2025

CodSpeed Performance Report

Merging #8582 will not alter performance

Comparing 01-18-fix_minifier_fix_dce_shadowed_undefined (7b219a9) with main (7421a52)

Summary

✅ 32 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 18, 2025
Copy link
Member Author

Boshen commented Jan 18, 2025

Merge activity

  • Jan 18, 4:02 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 18, 4:02 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 18, 4:11 AM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 01-18-fix_minifier_fix_dce_shadowed_undefined branch from 61a88dc to c560248 Compare January 18, 2025 09:02
@Boshen Boshen force-pushed the 01-18-fix_minifier_fix_dce_shadowed_undefined branch from c560248 to 7b219a9 Compare January 18, 2025 09:04
@graphite-app graphite-app bot merged commit 7b219a9 into main Jan 18, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-18-fix_minifier_fix_dce_shadowed_undefined branch January 18, 2025 09:11
Boshen added a commit that referenced this pull request Jan 19, 2025
## [0.47.1] - 2025-01-19

### Features

- ee8ee55 napi/parser: Add `.hasChanged()` to `MagicString` (#8586)
(Boshen)
- 1bef911 napi/parser: Add source map API (#8584) (Boshen)

### Bug Fixes

- 7b219a9 minifier: Fix dce shadowed undefined (#8582) (Boshen)
- 7421a52 transformer/typescript: Correctly resolve references to
non-constant enum members (#8543) (branchseer)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant