Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ-711: Modifying the details of a sale order in Odoo should update the respective entry in Superset's sale_order_lines table. #122

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

kdaud
Copy link
Contributor

@kdaud kdaud commented Jan 8, 2025

Ticket: https://mekomsolutions.atlassian.net/browse/OZ-711

This PR adds tests for Odoo → Analytics streaming and covers the following scenarios.

  • Revising an Odoo sale order line modifies the corresponding entry in Superset's sale_order_lines table.
  • Voiding an Odoo sale order line updates the corresponding entry in Superset's sale_order_lines table.
  • Deleting an Odoo quotation line removes the corresponding entry in Superset's sale_order_lines table.

@kdaud kdaud force-pushed the OZ branch 2 times, most recently from 8ad385a to 4a04449 Compare January 9, 2025 05:18
@kdaud kdaud changed the title Fix login error OZ-711: Modifying the details of a sale order in Odoo should update the respective entry in Superset's sale_order_lines table. Jan 9, 2025
@kdaud kdaud marked this pull request as ready for review January 9, 2025 14:19
…he respective entry in Superset's sale_order_lines table.
@@ -5,7 +5,7 @@ dotenv.config();

const config: PlaywrightTestConfig = {
testDir: './e2e/tests',
timeout: 10 * 60 * 1000,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The Keycloak-Odoo streaming requires a longer timeout due to its configuration, so I reduced the global timeout to 3 minutes and set longer timeouts for the relevant test cases.

Copy link
Contributor

@Ruhanga Ruhanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good. Find a few suggestions below.

e2e/tests/odoo-superset-flows.spec.ts Outdated Show resolved Hide resolved
e2e/tests/odoo-superset-flows.spec.ts Outdated Show resolved Hide resolved
@kdaud kdaud requested a review from Ruhanga January 10, 2025 05:40
Copy link
Contributor

@VaishSiddharth VaishSiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VaishSiddharth VaishSiddharth merged commit eaf496d into main Jan 15, 2025
@kdaud kdaud deleted the OZ branch January 17, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants