OZ-562: Refactored component-specific user actions #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mks-d
requested changes
May 7, 2024
|
I'm still debugging the tests to fix the build failures! |
|
The PR is ready to go into main. |
mks-d
requested changes
May 10, 2024
| await homePage.goToClients(); | ||
| await homePage.selectOpenMRSId() | ||
| await keycloack.goToClients(); | ||
| await keycloack.selectOpenMRSId() |
There was a problem hiding this comment.
Shouldn't it be more something like selectOpenMRSClient() to remain in Keycloak's lingo? Or this is UI-driven and there is literally something called ID on the screen?
There was a problem hiding this comment.
ActuallyselectOpenMRSClient() would imply something different however, this is UI-driven with a label called client Id on the screen.
| await homePage.goToClients(); | ||
| await homePage.selectSupersetId(); | ||
| await keycloack.goToClients(); | ||
| await keycloack.selectSupersetId(); |
There was a problem hiding this comment.
Same remark here about "id".
mks-d
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket OZ-562