Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVEX-179] Add a TF module to make mono-repository setup easier #148
base: main
Are you sure you want to change the base?
[DEVEX-179] Add a TF module to make mono-repository setup easier #148
Changes from all commits
af0b770
1b256d7
463b0c9
b53639a
1c224e2
5616c35
4a51a2c
8052cb1
ce9eee9
728cd0e
bac6ad8
e427c8b
68e01ac
4f64867
7676f4f
80a3f2e
854f81e
3aa092a
61a49ce
be66fd2
352a41b
042480e
f57da78
e78c254
c1014cb
477b3bb
d0bff61
c4ad319
eace19f
c48949d
37fa86b
8e5126b
cd9a33d
454f327
f92e530
10dff20
7fcaea9
fb9a8e0
b12acee
8fb26cd
6c1d5d3
73cdc18
2ad26c7
2d261c0
9adf5a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any value in having the branch up to date before merging as CI pipelines run over the merge commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you elaborate a little bit more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we're talking about monorepository (aka a single, potentially large repository), there is an high possibility that PR's branch is not up to date with
main
as other people are working on the same code base. I don't see this as an issue because the delta does not affect the validity of CI checks nor "manual" review as changes are on different paths. On the other hand, if changes are on the same files it is likely to have conflicts and PR cannot be mergedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's see what @pagopa/engineering-team-devex thinks about this