[CES-614] Added custom roles into Core Infra module #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8673fbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gunzip
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Copilot reviewed 3 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (5)
- infra/modules/azure_core_infra/_modules/custom_roles/data.tf: Language not supported
- infra/modules/azure_core_infra/_modules/custom_roles/locals.tf: Language not supported
- infra/modules/azure_core_infra/_modules/custom_roles/outputs.tf: Language not supported
- infra/modules/azure_core_infra/_modules/custom_roles/roles.tf: Language not supported
- infra/modules/azure_core_infra/main.tf: Language not supported
Comments suppressed due to low confidence (1)
infra/modules/azure_core_infra/_modules/custom_roles/README.md:27
- [nitpick] The output name
pagopa_apim_list_secretsis ambiguous. Consider renaming it to something more descriptive likepagopa_api_management_list_secrets_role.
| <a name="output_pagopa_apim_list_secrets"></a> [pagopa\_apim\_list\_secrets](#output\_pagopa\_apim\_list\_secrets) | n/a |
|
Is this ready for review? |
|
This PR is now moved into this pagopa/eng-azure-governance#159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Added custom roles definition into module for core infrastructure.
Motivation and context
To permit least privilege for RBAC we can define custom roles in core infrastructure, the added role is to list secrets, useful to avoid Role
API Management Service Contributorfor a CI identity, with this we can useAPI Management Service Readerin combo with new onePagoPA API Management Service List SecretsType of changes
Does this introduce a change to production resources with possible user impact?
Other information