chore: [IOBP-392] Refactor TimelineOperationListItem component
#5200
Conversation
pagopa-github-bot
changed the title
TimelineOperationListItem componentTimelineOperationListItem component
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5200 +/- ##
==========================================
+ Coverage 47.69% 47.96% +0.26%
==========================================
Files 1544 1544
Lines 32032 32036 +4
Branches 7876 7863 -13
==========================================
+ Hits 15278 15366 +88
+ Misses 16704 16620 -84
Partials 50 50
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| /> | ||
| ); | ||
| }; | ||
|
|
||
| const TimelineOperationListItemSkeleton = () => ( | ||
| const SuspendOperationListItem = ( |
There was a problem hiding this comment.
I believe that dividing all the listItems like this, rather than just picking the props with the original switch and then using them to render, adds a lot of verbosity for more downsides than benefits; what do you think?
There was a problem hiding this comment.
Could you give me some examples?
You mean, instead of React components we should just make regular function to return the props to pass to a ListItemTransaction? Wouldn't you find it difficult to debug and/or mantain instead of just regular React components?
There was a problem hiding this comment.
I tried your suggestion 1578852
I agree with you, I think it's more readable. Let me know!
Short description
This PR refactors the
TimelineOperationListItemcomponent and implements new logic to correctly displayCANCELLEDandREVERSALtransactions and CIE onboarding operations.RocketSim_Recording_iPhone_13_2023-11-06_17.47.03.mp4
List of changes proposed in this pull request
TimelineOperationListIteminto sub-component easier to manage.How to test
io-dev-serveron this branch: refactor: ID Pay timeline data refactoring io-dev-api-server#316